rustdesk / rustdesk/rustdesk-server-pro

LDAP Doesn't escape commas in DN when binding user

Open
#756 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Shell
Stars
317
Forks
119
PR merge metrics
No merged PRs in 30d

Description

Bug Description

When using LDAP with Windows AD, It appears that if a CN contains a comma it will fail to bind the user as the DN will contain the comma as well. Even though the escape is accounted for in the DN itself. All of our CN's contain commas. You get error "Verification failed, please confirm that the username and password are correct." until the comma is removed.

Example

User
Doe, John

DN
CN=Doe, John,OU=IT,OU=Employees,DC=company,DC=com

Thank you :)

How to Reproduce

Update a users Common Name in AD to something like Doe, Joe and try and login. Login will Fail unless the comma is removed

Expected Behavior

Should be able to login if the CN contains a comma or not.

Operating system(s) on local (controlling) side and remote (controlled) side

Windows 11

RustDesk Version(s) on local (controlling) side and remote (controlled) side

RustDesk Server Pro 1.6.3

Screenshots
Image
Additional Context

No response

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file, test, or entry point is named. Start by reproducing the login failure with an Active Directory common name such as “Doe, John” and inspect the LDAP binding path; done means authentication succeeds when the DN contains an escaped comma.

Written by the indexing model from the issue text.

Assessment

Domain
authentication, backend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.