rust-windowing / rust-windowing/winit

Make log an optional dependency behind "logging"

Open
#2,541 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

S - maintenance
Dominant language
Rust
Stars
6.2k
Forks
1.3k
Avg merge
2d 19h
Merged PRs (30d)
9

Description

log could be enabled when feature "logging" is enabled and it could be included by default.

We can define a log! (info!, warn!...) macro with same signature as that from the log crate which calls log's macros if we have the feature enabled and otherwise do a no-op.

Seems like a low-hanging fruit to get one dependency less and It really shouldn't be required by a windowing library I feel.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the log dependency, the feature definitions, and all current logging call sites in the winit repository. Check how the logging feature should behave when enabled or disabled, then verify that the dependency is optional, the feature is enabled by default if intended, and disabled logging remains a no-op.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
desktop
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.