rust-windowing / rust-windowing/winit

Size bug with window.set_decorations(false)

Open
#2,109 1 comment 0 reactions 1 assignee View on GitHub

@maroider is already working on this.

Since Dec 23, 2021.

B - bug C - needs investigation DS - win32
Dominant language
Rust
Stars
6.2k
Forks
1.3k
Avg merge
2d 19h
Merged PRs (30d)
9

Description

Describe the bug
When using window.set_decorations(false) with a fixed size, the window is slightly too big, so it has black borders

To Reproduce
Set up a window with fixed size then set window.set_decorations(false)

Expected behavior
To have a frameless window of the size i gave it

Screenshot
image

The code in question
use image::{DynamicImage, ImageBuffer, Rgba};
use pixels::{Pixels, SurfaceTexture};
use winit::{
    dpi,
    event::{DeviceEvent, ElementState, Event, MouseButton, VirtualKeyCode, WindowEvent},
    event_loop::{ControlFlow, EventLoop},
    window::WindowBuilder,
};

fn main() {
    let im: DynamicImage = image::open("Thresh_6.png").unwrap();
    let rgba: ImageBuffer<Rgba<u8>, Vec<u8>> = im.to_rgba8();

    let width = rgba.width();
    let height = rgba.height();

    println!("{} x {}", width, height);
    // Prints 1215 x 717 (the correct image size)

    let event_loop = EventLoop::new();

    let window = WindowBuilder::new()
        .with_inner_size(dpi::LogicalSize::new(width, height))
        .build(&event_loop)
        .unwrap();

    window.set_decorations(false);

    let window_size = window.inner_size();

    println!("{} x {}", window_size.width, window_size.height);
    // Prints 1231 x 756 for some reason

    let surface_texture = SurfaceTexture::new(window_size.width, window_size.height, &window);

    let mut pixels = Pixels::new(width, height, surface_texture).unwrap();

    let data = rgba.into_vec();
    let frame = pixels.get_frame();

    for (index, i) in data.iter().enumerate() {
        frame[index] = *i;
    }

    event_loop.run(move |event, _, control_flow| {
        *control_flow = ControlFlow::Poll;

        *control_flow = ControlFlow::Wait;

        match event {
            Event::WindowEvent { event, .. } => match event {
                WindowEvent::CloseRequested => {
                    println!("The close button was pressed; stopping");
                    *control_flow = ControlFlow::Exit
                }
                WindowEvent::MouseInput { state, button, .. } => match button {
                    MouseButton::Left => match state {
                        ElementState::Pressed => {
                            window.drag_window().unwrap();
                        }
                        _ => {}
                    },
                    _ => {}
                },
                _ => {}
            },
            Event::MainEventsCleared => {
                window.request_redraw();
            }
            Event::RedrawRequested(_) => {
                let _render_result = pixels.render_with(|encoder, render_target, context| {
                    context.scaling_renderer.render(encoder, render_target);
                    Ok(())
                });
            }
            Event::DeviceEvent {
                device_id: _,
                event: DeviceEvent::Key(keyboard_input),
            } => match keyboard_input.virtual_keycode {
                Some(code) => match code {
                    VirtualKeyCode::Escape => *control_flow = ControlFlow::Exit,
                    _ => {}
                },
                None => {}
            },
            _ => (),
        }
    });
}

The image used in the code: Thresh_6.png

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.