rust-osdev / rust-osdev/acpi

Mention calling `\_PIC` AML method in docs

Open
#356 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
245
Forks
93
Avg merge
2d 8h
Merged PRs (30d)
15

Description

https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html?highlight=_pic#pic-method

It would help people using this library. Also, maybe we could add a higher level function with an enum for

0 – PIC mode
1 – APIC mode
2 – SAPIC mode

See #355. In my OS I was really confused why the AML interpreter was saying eHCI interrupts are [0x0] (and sometimes [0xE]), when it should've returned [0x10].

I will make a PR documenting this and adding a high level function, maybe something called set_interrupt_model_used(interrupt_model: InterruptModelUsed) on the AML interpreter.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the AML interpreter API, issue #355, and the ACPI specification's _PIC method. Define the InterruptModelUsed enum and the proposed set_interrupt_model_used entry point, while documenting when _PIC must be called. Done means the behavior and the new high-level API are documented and usable by library consumers.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
documentation, operating-systems
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.