rust-osdev / rust-osdev/acpi

Many panic!() / unwrap() calls in parse_field_list

Open
#354 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
245
Forks
93
Avg merge
2d 8h
Merged PRs (30d)
15

Description

This is a low priority unfixed issue from The Mega Issue (https://github.com/rust-osdev/acpi/issues/315)

It's probably worth making some of the panics into Errors, at some point.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the parse_field_list entry point and read the linked Mega Issue #315 for the broader context. Inventory the panic! and unwrap() paths there, determine which can return Errors without changing valid parsing behavior, and confirm that the selected cases are no longer unrecoverable panics.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.