rust-osdev / rust-osdev/acpi

Rsdp::search_for_on_bios reads EBDA segment without validation

Open
#353 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
245
Forks
93
Avg merge
2d 8h
Merged PRs (30d)
15

Description

This is a low priority unfixed issue from The Mega Issue (#315)

To quote Isaac:

"We read from the EBDA segment address from the BIOS Data Area without validation. If corrupted or called on a UEFI-only system, bad things could happen. We could potentially add some validation here?"

There's not masses to be done - perhaps even nothing more than adding a Safety: constraint of Don't call on a BIOS system

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Rsdp::search_for_on_bios and reading how it obtains the EBDA segment address from the BIOS Data Area. Check the existing safety documentation and surrounding ACPI assumptions; done means the issue's validation or Safety constraint is addressed and the behavior is covered by the project's relevant tests, if any are found.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.