rust-osdev / rust-osdev/acpi

Pm1EventRegisterBlock::set_event_enabled race condition?

Open
#327 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
245
Forks
93
Avg merge
2d 8h
Merged PRs (30d)
15

Description

The method takes an &self, but it reads the current register value, modifies it, and then writes the value. This can cause a race condition, right? Because the method kind of implies that it's an atomic operation when it isn't, so it could cause unexpected results if for some reason people call it from multiple threads at the same time.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Pm1EventRegisterBlock::set_event_enabled and trace its register read and write, then inspect how callers can invoke it across threads. Establish whether concurrent calls can lose updates and clarify the method's intended atomicity contract. Done means the race concern is resolved or explicitly ruled out.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.