rust-osdev / rust-osdev/acpi

BufferField implicit conversion not supported in OperationRegion command

Open
#273 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
245
Forks
93
Avg merge
2d 8h
Merged PRs (30d)
15

Description

NB: This issue repros only if #272 is worked around, otherwise that hits first.

My machine has an ASL block that simplifies down the snippet at below. The crate can't parse the OperationRegion command - ObjectNotOfExpectedType { expected: Integer, got: BufferField }.

I think BufferField should be implicitly converted to Integer here (and possibly other places too)?

Failing snippet

DefinitionBlock ("", "SSDT", 2, "AMD", "AmdTable", 0x00000002)
{
    Scope (\_SB)
    {
        Name (ADAT, Buffer (0x0010) //keep
        {
            /* 0000 */  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,  // ........
            /* 0008 */  0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00,  // ........

        })

        Device (AWR0)
        {
            Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard Resources */)  // _HID: Hardware ID
            Name (_UID, 0x90)  // _UID: Unique ID
            Device (ABR0)
            {
                Name (_HID, EisaId ("PNP0C02") /* PNP Motherboard Resources */)  // _HID: Hardware ID
                Name (_UID, 0x80)  // _UID: Unique ID
                OperationRegion (A053, SystemMemory, (DerefOf (\_SB.ADAT [(0x04)])), 0x1000) // <--- this line fails
                Field (A053, ByteAcc, NoLock, Preserve)
                {
                    Offset (0x18),
                    A, 8
                }
            }
        }
    }
}

Quite happy to take a look if you give me a summary of how this is intended to work.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failing ASL snippet and trace the OperationRegion command handling, especially the DerefOf expression that yields a BufferField. Read the existing AML value-conversion rules and related tests, if present. Done means this OperationRegion parses successfully with the expected integer address, with regression coverage for the snippet.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
65/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.