Rename `scaled_add` to `add_assign_scaled` or equivalent

Open
#926 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
data

Research direction

Start with the scaled_add method linked in the issue and review its current API and documentation. The issue proposes several replacement names but does not select one or mention files or tests; completion would require an agreed name and updating all affected references and coverage.

Written by the indexing model from the issue text.

Description

Personally, the name scaled_add makes me think that the operation is self = alpha * self + rhs, not self += alpha * rhs. What do you think of changing the name to add_scaled or add_scaled_inplace?

Dominant language
Rust
Stars
4.3k
Forks
391
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-ndarray/ndarray

All issues in rust-ndarray/ndarray

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.