BaseArray::abs(&self) isn't implemented for integers (isize, i64, etc)

Open
#1,462 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
data

Research direction

Start by locating BaseArray::abs(&self) and the “Element-wise methods for float arrays” section. Compare the existing float implementation with integer array APIs and their tests, then determine what coverage is needed for signed integer arrays; done means negative integer arrays can produce their absolute values through abs(&self).

Written by the indexing model from the issue text.

Description

enhancement

The abs(&self) method in BaseArray only works for float arrays since it's defined as part of the Element-wise methods for float arrays section.

However, in my opinion, we should also be able to get the absolute version of negative integers arrays.

Dominant language
Rust
Stars
4.3k
Forks
391
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-ndarray/ndarray

All issues in rust-ndarray/ndarray

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.