rust-mobile / rust-mobile/ndk

Remove `abort_on_panic()` since Rust 1.81?

Open
#488 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
1.3k
Forks
125
PR merge metrics
No merged PRs in 30d

Description

In https://github.com/rust-mobile/ndk/pull/412 @spencercw neatly added a wrapper to catch panics instead of unsoundly unwinding them across an extern "C" boundary. Rust 1.81 now plugged that hole and always aborts already:

https://blog.rust-lang.org/2024/09/05/Rust-1.81.0.html#abort-on-uncaught-panics-in-extern-c-functions

This should allow us to get rid of the manual catch+abort when our MSRV is 1.81. Unsure if that gets propagated in the same detail to stderr / Android logs though.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Review PR #412 and the Rust 1.81 release note first, then locate the abort_on_panic wrapper and its callers; done means the manual catch-and-abort path is removed for the updated MSRV while stderr and Android log behavior remain acceptable.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, rust
Domain
mobile-dev
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.