rust-lang / rust-lang/team

Rename BranchProtections to Rulesets in v1 API

Open
#2,441 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
363
Forks
369
Avg merge
1d 54m
Merged PRs (30d)
59

Description

We converted branch protections to rulesets (see https://github.com/rust-lang/team/issues/2356).
However V1 API still uses the term branch protection. See:

https://github.com/rust-lang/team/blob/783fa09ace9b89f1b922bcb094fa3120dce9d5f2/rust_team_data/src/v1.rs#L178

Rename this field to rulesets, controlling the deployment of all clients that depend on this field (for sure triagebot).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in rust_team_data/src/v1.rs around line 178 and inspect how the V1 field is serialized and consumed by clients, especially triagebot. Verify the field is consistently exposed as rulesets and that dependent clients still build or pass their existing checks without the old branch-protection name.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
70/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.