rust-lang / rust-lang/team

Dry-check should check for minimum `write` access to `<repo>` in `bors.<repo>.review = true`

Open
#1,842 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-enhancement
Dominant language
Rust
Stars
363
Forks
368
Avg merge
1d 54m
Merged PRs (30d)
59

Description

See e.g.https://github.com/rust-lang/team/pull/1841

If a team has bors.rust.review = true, they can r+ PRs on rust-lang/rust. Surely if they can r+ PRs they should at the minimum have write access to said repo? Otherwise, the team won't even have triaging perms.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review rust-lang/team#1841 and locate the dry-check entry point that validates bors.<repo>.review = true. Determine how repository permissions are checked, then make the configuration require at least write access to the referenced repository. Done means dry-check rejects teams lacking write access while preserving valid review configuration checks.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
authorization
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.