Fix xsaves and xsaves64 tests
Open
Nobody has claimed this yet.
A-x86
- Dominant language
- Rust
- Stars
- 694
- Forks
- 336
- Avg merge
- 5d 14h
- Merged PRs (30d)
- 9
Description
So after #211 is merged, this is the current state of affairs:
xsaves,xsaves64, andxsetbvcannot be easily tested because they require privileged mode- all other
xsaveintrinsics are tested ini586,i686, andx86_64 - the following intrinsics fail on travis when using Intel's Software Development Emulator version: 8.12.0-2017-10-23, these are disabled from that test run using
#[cfg(not(feature = "intel_sde"))]:i586::xsaveoptandx86_64::xsaveopt64i586::xsavecandx86_64::xsavec64x86_64::xsave64
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the changes in #211 and the existing xsave intrinsic tests for i586, i686, and x86_64. Check how privileged xsaves, xsaves64, and xsetbv are handled and how the intel_sde configuration excludes failing cases; done means the relevant tests run appropriately across the listed targets and emulator configuration.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100