rust-lang / rust-lang/stdarch

Change PR strategy from rebase to merge?

Open
#1,501 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
694
Forks
336
Avg merge
5d 14h
Merged PRs (30d)
9

Description

rust-lang repositories usually "merge" their PRs rather than rebasing them. This repo is an exception. According to @Amanieu, it's been like that for a while and it is unclear why.

IMO we should switch this repo to use "merge" rather than "rebase". However I also just realized that this repo doesn't use bors, is that somehow related to the use of rebases?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the discussion in PR #1497 and the repository's current pull-request workflow, focusing on why it uses rebase and whether that is related to not using bors. Done means reaching a decision on the merge strategy and documenting or applying the agreed repository-level change.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.