rust-lang / rust-lang/stdarch

Inlining checks are broken for arm

Open
#1,210 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
694
Forks
336
Avg merge
5d 14h
Merged PRs (30d)
9

Description

Inlining is not checked in the automated tests for arm.

There are some arm neon intrinsics for which the compiled test shims contain subroutine calls to other intrinsics.

Also the deduplication guard code is to heavy for arm and is emitted as function calls for some tests causing false positives once the inlining checks are enabled.

PR will follow once #1208 has landed.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by reviewing the automated ARM tests and the status of #1208; identify the ARM NEON shims with subroutine calls and the deduplication guard paths, then confirm the inlining checks no longer report those calls as failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.