rust-lang / rust-lang/std-dev-guide
Stabilizing features page contains confusing link for finding libs team reviewers
Nobody has claimed this yet.
- Dominant language
- Shell
- Stars
- 90
- Forks
- 47
- Avg merge
- 9h 22m
- Merged PRs (30d)
- 1
Description
The When is an FCP appropriate? section on the "Stabilizing features" page contains the following text:
If you're unsure if a feature is ready for stabilization the first step should be to ask in the relevant tracking issue and get assistance from other participants in that discussion. In some cases the tracking issue may not have many other active participants, so if you're ever having trouble getting any feedback please ping one of the libs team reviewers directly to request assistance.
The link for finding a libs team reviewer is https://github.com/rust-lang/rust/blob/master/triagebot.toml, which seems to contain the following list of people:
[assign.adhoc_groups]
libs = [
"@Mark-Simulacrum",
"@workingjubilee",
"@jhpratt",
"@tgross35",
"@thomcc",
"@ibraheemdev",
]
However https://www.rust-lang.org/governance/teams/library contains a completely different list of people:
@Amanieu
@m-ou-se
@cuviper
@joshtriplett
@the8472
@thomcc
Maybe the first list is actually the correct one, but the second list seems to be the correct one.
I think the link you should be changed in the guide or it should contain some explanation of how to find the libs team reviewers from the lnik provided.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the “When is an FCP appropriate?” section on the “Stabilizing features” page and compare its libs team reviewers link with the Rust governance team page and triagebot.toml list. Resolve which source or explanation is appropriate, then update the link or surrounding text so readers can find the correct reviewers.
Written by the indexing model from the issue text.
Assessment
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100