rust-lang / rust-lang/rustwide

Some commands don't work with CI builds but could

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
198
Forks
45
Avg merge
18h 46m
Merged PRs (30d)
7

Description

https://github.com/rust-lang/docs.rs/pull/1892/files#diff-b06b44e6583254ce69af8cedabc04a73a97599d593676e1bbad7ee442240ccf1R121-R128

When using a CI build, commands like this fail:

        let res = Command::new(&self.workspace, self.toolchain.rustc())
            .args(&["--version"])
            .log_output(false)
            .run_capture()?;

That's because rustwide tries to invoke:

$ rustc +6703d43029387eef125596dd7071d0d4fab902c3 --version
error: toolchain '6703d43029387eef125596dd7071d0d4fab902c3' is not installed

@jyn514 proposed we could solve this either by invoking the CI binary directly, or by running rustup toolchain link.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked docs.rs pull request diff around lines 121-128 and trace the Command invocation for CI builds. Compare invoking the CI binary directly with using rustup toolchain link, then verify that commands such as rustc --version work with CI toolchains without reporting them as uninstalled.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.