Proposal: special toolchain names referring to particular override levels
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 22h 40m
- Merged PRs (30d)
- 46
Description
Part of https://github.com/rust-lang/rustup/issues/4059.
Since https://github.com/rust-lang/rustup/pull/4932 it has been decided that only characters satisfying GeneralSecurityProfile::identifier_allowed() should be allowed in rustup toolchain names.
This has opened up new possibilities for us to assemble our special/reserved toolchain names as needed with special characters such as @ or =.
Following up the above efforts, noting the five levels of rustup toolchain overrides:
- The
+<toolchain>override.- The
RUSTUP_TOOLCHAINenvironment variable.- The
rustup override setoverride.- The
rust-toolchain.tomloverride.- The default toolchain.
... aiming to address https://github.com/rust-lang/rustup/issues/4391, I propose the following changes:
- Make
envanddefaultnew reserved words in addition to the existingnone. - Introduce the following toolchain syntax:
env: Refers to the toolchain that should be activated by the env override.- This will not be useful per se but sometime people want to be explicit, e.g.
rustup run env cargoinstead ofcargo.
- This will not be useful per se but sometime people want to be explicit, e.g.
dir=<dir>: Refers to the toolchain that should be activated by the dir override on<dir>or its fallback dirs.- e.g.
cargo +dir=./crates/download
- e.g.
file=<file>: Refers to the toolchain that should be activated by the TOML override in<file>which follows therust-toolchain.tomlschema.- e.g.
cargo +file=windows.toml, for a Windows-specificrust-toolchain.tomlsetup.
- e.g.
default: Refers to the default toolchain. Bails out if none is set.- e.g.
cargo +default
- e.g.
Concerns
- How should we handle the error for
dir=andfile=when the dir/TOML override doesn't exist? Should we bail out or warn and fall back to the next level?- My guess is that we should warn and fall back.
- Consider the relation between this proposal and #4945. Should we resolve the toolchain name when the user issues
rustup default file=windows.toml? If so, should we fully resolve or partially resolve it?- My guess is that we should partially resolve to an official or a custom toolchain name (that isn't a reserved word and doesn't have special characters like
=).
- My guess is that we should partially resolve to an official or a custom toolchain name (that isn't a reserved word and doesn't have special characters like
- Can we use this in
RUSTUP_TOOLCHAIN(isRUSTUP_TOOLCHAINnot guaranteed to be a parsable toolchain name by downstreams other than rustup)? If we can, we will also resolve #2793 at the same time by settingRUST_TOOLCHAIN=default.- I think we probably can.
Note
This also simplifies https://github.com/rust-lang/cargo/issues/10098 because this involves changing the override lookup logic to work with arbitrary base paths. In that case, we'd just need to alter the path for our dir/TOML override source by prefixing it with the path passed via cargo -C.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.