rust-lang / rust-lang/rustup

Provide a warning when using custom toolchains with extra components

Open
#4,252 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
22h 40m
Merged PRs (30d)
46

Description

#4250 currently does not provide any custom toolchain validity check when provided with extra components, such as in the configuration below:

[toolchain]
channel = "ms-1.84.1"
targets = [
    "aarch64-pc-windows-msvc",
    "x86_64-pc-windows-msvc",
]

I think it will probably be worthwhile to add a warning clarifying that we are not doing any checks, as demonstrated in the new test.
https://github.com/rust-lang/rustup/issues/4250#issuecomment-2722983959

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading issue #4250 and the linked discussion about custom toolchain validity checks, then inspect the configuration handling for extra components. Add the warning described in the issue and confirm the behavior with the new test referenced in the discussion.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.