Tests relying on `reqwest::Client` may fail with "dispatch task is gone: runtime dropped the dispatch task"
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 22h 40m
- Merged PRs (30d)
- 46
Description
Verification
- I searched for recent similar issues at https://github.com/rust-lang/rustup/issues?q=is%3Aissue+is%3Aopen%2Cclosed and found no duplicates.
- I am on the latest version of Rustup according to https://github.com/rust-lang/rustup/tags and am still able to reproduce my issue.
Problem
This is causing irregular failures for different CI platforms:
- Linux
- https://github.com/rust-lang/rustup/actions/runs/9303236385/job/25605096671
- https://github.com/rust-lang/rustup/actions/runs/9354772182/job/25748366479
- https://github.com/rust-lang/rustup/actions/runs/9337787790/job/25700115067
- https://github.com/rust-lang/rustup/actions/runs/9343224087/job/25712479916
- Windows
The error message here is identical (although the exact test that failed might differ):
running 395 tests
...
test suite::cli_exact::check_updates_with_update ... FAILED
error: could not download file from 'https://static.rust-lang.org/rustup/release-stable.toml' to '/tmp/rustup-updateD58GcC/release-stable.toml': failed to make network request: error sending request for url (https://static.rust-lang.org/rustup/release-stable.toml): client error (SendRequest): dispatch task is gone: runtime dropped the dispatch task
Notes
Possibly related to https://github.com/hyperium/hyper/issues/2312, https://github.com/Azure/azure-sdk-for-rust/pull/1550 or https://github.com/fussybeaver/bollard/issues/387#issuecomment-2008133973.
I'm pretty sure that #3367 has caused this.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the suite::cli_exact::check_updates_with_update test and the reqwest::Client usage, then review the change introduced by issue #3367 and the linked CI failures. Reproduce the intermittent error on the affected platforms; done means the relevant tests no longer fail with a dropped dispatch task.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, rust
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100