rust-lang / rust-lang/rustup

test suite fails when run within a dir containing rust-toolchain{.toml}

Open
#3,339 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
22h 40m
Merged PRs (30d)
46

Description

We have no mechanism for opting out of rust-toolchain files.

The test suite runs in a subdir of the source tree.

Placing the source tree inside a directory containing a rust-toolchain file then applies a rust-toolchain file to every test that doesn't explicitly create one itself, which will almost certainly fail some tests - spuriously.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by examining how the test suite runs from a subdirectory of the source tree and how rust-toolchain files are discovered. Confirm the behavior when the source tree is nested under an external rust-toolchain file; done means tests no longer inherit that file unless they explicitly create or select one.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.