rust-lang / rust-lang/rustup

rustup doc bad path separator on windows

Open
#3,081 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
22h 40m
Merged PRs (30d)
46

Description

Problem

Windows 10
Version 21H2 Build (19044.2006)

rustup 1.25.1 (bb60b1e89 2022-07-12)

The path to the file index.html is build by concatenating the folder and "index.html".
On Windows "/" instead of "" is used.

Steps
  1. rustup doc --book
  2. firefox fails to open D:\Rust\toolchains\stable-x86_64-pc-windows-msvc\share\doc\rust\html\book/index.html
  3. Should be D:\Rust\toolchains\stable-x86_64-pc-windows-msvc\share\doc\rust\html\book\index.html
Possible Solution(s)

No response

Notes

No response

Rustup version
rustup 1.25.1 (bb60b1e89 2022-07-12)
Installed toolchains
Default host: x86_64-pc-windows-msvc
rustup home:  D:\Rust

installed toolchains
--------------------

stable-x86_64-pc-windows-gnu
stable-x86_64-pc-windows-msvc

installed targets for active toolchain
--------------------------------------

wasm32-unknown-unknown
x86_64-pc-windows-msvc

active toolchain
----------------

stable-x86_64-pc-windows-msvc (default)
rustc 1.64.0 (a55dd71d5 2022-09-19)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the implementation of the rustup doc --book command and trace how it builds the path to book/index.html. Reproduce the command on Windows, then verify that Firefox receives a valid Windows path with the correct separator.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
cli, operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.