rust-lang / rust-lang/rustup

rustup should not delete the entire ~/.rustup/tmp dir

Open
#2,246 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
22h 40m
Merged PRs (30d)
46

Description

Rustup should only remove the tmp/<toolchain> dir that it downloaded

When rustup-toolchain-install-master (RTIM) and rustup update run concurrently, rustup often finishs
installation first (probably because of nightly toolchain is cache by cloudfont, I don't know), so
the tmp is removed by rustup. This cause RTIM fails to install the master toolchain.

Describe the solution you'd like

I don't have a clear suggestion. But I think rustup could keep the tmp dir, and only remove
the toolchain that it is going to install.

Notes

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing concurrent rustup update and rustup-toolchain-install-master runs, then trace the cleanup of ~/.rustup/tmp. Done means rustup removes only the tmp/ directory it downloaded and concurrent installation no longer fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.