Rustup output should end with a newline
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 22h 40m
- Merged PRs (30d)
- 46
Description
Problem
Rustup's output ends with a [0m after its last newline.
But command-line tools are typically expected to end their output with a newline.
In a CLI context, this doesn't matter as that character sequence "resets" the color without producing visible output. But in a log-parsing context this does matter, as the next line has this weird escape-sequence prefix. This caused a (minor) bug here. The output looked like
[1minfo: (B[mdownloading component 'rustfmt'
[1minfo: (B[minstalling component 'rustfmt'
[0m[taskcluster 2019-06-10 16:36:58.754Z] === Task Finished ===
[taskcluster 2019-06-10 16:36:58.755Z] Successful task run with exit code: 0 completed in 238.573 seconds
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named in the issue. Start by reproducing rustup output in a log-parsing context and trace the CLI output path that emits the final reset sequence. Done means rustup output ends with a newline without leaving the escape sequence as the next line's prefix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100