Misconfiguration no longer detected
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 22h 40m
- Merged PRs (30d)
- 46
Description
With https://github.com/rust-lang-nursery/multirust-rs/commit/c3679a5922e68c5b08d7ff544f4d76031887523d the proxy test was removed. While I understand the rationale for it's removal, I do think it was useful:
-
On windows, the system-wide PATH has a higher precedence than the user-specific PATH, so by default, any existing rust install will silently override the rustup install, and the invocations of rustc will not be correctly proxied. Given how likely this is to occur, we should at least warn when this is happening.
-
Previously, multirust would intercept commands of the form
<proxy> --multirustand print a message indicating that said proxy is working correctly. This was a useful feature in itself, and does not cause erroneous warnings.
There are a couple of ways this could be solved:
- Only check the proxies on first install.
- Provide a command to check that the proxies are correctly configured, and recommend using it in the post-install message.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review commit c3679a5922e68c5b08d7ff544f4d76031887523d and the removed proxy test first. Reproduce the Windows PATH precedence case and compare it with the former <proxy> --multirust behavior. The issue is complete when the chosen approach reliably identifies or checks misconfigured proxies and communicates the result during installation or through a command.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100