Fix 'show' displaying UNC paths on windows
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 22h 40m
- Merged PRs (30d)
- 46
Description
After https://github.com/rust-lang-nursery/rustup.rs/pull/1172 several test cases in cli-rustup will be ignored because rustup is unexpectedly showing UNC (\\?\) file paths (and show_toolchain_override is disabled today), probably because of the normalization being done to the paths during the override directory walk.
When these paths are reported, they probably need to be converted back to non-UNC paths where it is unambiguous, or perhaps should not be converted to UNC in the first place. I do not know the semantics here well enough to know why the paths need to be converted to UNC in the first place, or in which cases they don't need to be. Maybe @Diggsey or @retep998 can say.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the normalization performed during the override directory walk and the affected cli-rustup cases, including show_toolchain_override. Determine when Windows paths become UNC paths and verify the relevant output no longer unexpectedly displays UNC prefixes, with the previously disabled coverage restored where appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- cli, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100