rust-lang / rust-lang/rustup

remove_override_nonexistent test is flaky on windows

Open
#1,103 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
22h 40m
Merged PRs (30d)
46

Description

It might be because of TempDir failing to delete the directory. Upgrading to a tempdir that contains the aggressive remove_dir_all patch could fix it.

cc https://github.com/rust-lang-nursery/rustup.rs/pull/1102

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the remove_override_nonexistent test and inspect how it uses TempDir; the issue suggests upgrading the tempdir dependency to include its aggressive remove_dir_all patch. Run the test on Windows and verify that it no longer flakes because the temporary directory cannot be removed.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
testing-qa
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.