Ugly formatting
Open
Nobody has claimed this yet.
A-call-chains
C-bug
I-poor-formatting
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
/// Returns n_1, b_1, n_2, b_2
fn distribute(sum: u64) -> (u64, u64, u64, u64) {
let mut a = sum;
// ...
if a == 1 {
// ...
} else {
let kmax: u64 = a.ilog2().into();
let pow_2_kmax: u64 = (2_i32
.pow(kmax.try_into().expect("k_max could not convert into u32")))
.try_into()
.expect("2^(k_max) could not convert to u64");
return (kmax + 1 + m, 1, a - pow_2_kmax + 1 + m, a - pow_2_kmax);
}
}
What I would expect:
/// Returns n_1, b_1, n_2, b_2
fn distribute(sum: u64) -> (u64, u64, u64, u64) {
let mut a = sum;
// ...
if a == 1 {
// ...
} else {
let kmax: u64 = a.ilog2().into();
let pow_2_kmax: u64 = (2_i32
.pow(kmax.try_into().expect("k_max could not convert into u32")))
.try_into()
.expect("2^(k_max) could not convert to u64");
return (kmax + 1 + m, 1, a - pow_2_kmax + 1 + m, a - pow_2_kmax);
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the formatting of the distribute function shown in the issue and trace the formatter behavior that produces the nested .pow(...) indentation. Done means the formatted output matches the expected example, with the continuation and chained .try_into() aligned as shown.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100