rust-lang / rust-lang/rustfmt

Rendered width of \t in line width calculation isn't fixed to config.tab_spaces()

Open
#6,904 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs-triage
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Not necessarily something we need to address in this PR since you're trying to follow the existing logic, but the rendered width of any \t characters isn't going to be fixed to config.tab_spaces(). It'll vary depending on where the \t is in the line.

View changes since the review

Originally posted by @ytmimi in https://github.com/rust-lang/rustfmt/pull/6902#discussion_r3288884209

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Start by tracing rustfmt's line-width calculation and how tab characters are measured relative to config.tab_spaces(); done means their rendered width is fixed to that configuration rather than varying with their position in the line.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.