Comma gets duplicated in a macro params, obstructed by inline comments
Open
Nobody has claimed this yet.
A-comments
A-macros
C-bug
I-invalid-code
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
This is somewhat similar to #6759 but seem to have a different cause as this is a macro param bug
fn main() {
println!("Magic one to two commas -->" /**/, /**/);
}
Running cargo fmt on this adds another comma after the last /**/:
fn main() {
println!("Magic one to two commas -->" /**/, /**/,);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the Rust snippet and trace rustfmt's handling of macro parameters containing inline comments. Add a regression test for the duplicate comma and verify that formatting preserves the original comma count.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100