Extraneous newlines around `macro_rules!` rules not removed if body can not be formatted
Open
Nobody has claimed this yet.
needs-triage
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
macro_rules! x {
() => {};
}
// =>
macro_rules! x {
() => {};
}
macro_rules! x {
() => {let _ = {(x).disahkd.dusgd};};
}
// =>
macro_rules! x {
() => {
let _ = { (x).disahkd.dusgd };
};
}
macro_rules! x {
() => {!};
}
macro_rules! x {
() => {&};
}
macro_rules! x {
() => {.};
}
macro_rules! x {
() => {
let x = this.is.valid.so.far.but.missing.semicolon
};
}
// =>
macro_rules! x {
() => {!};
}
macro_rules! x {
() => {&};
}
macro_rules! x {
() => {.};
}
macro_rules! x {
() => {
let x = this.is.valid.so.far.but.missing.semicolon
};
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the supplied macro_rules! examples and trace the formatter entry point for macro_rules! handling. Verify completion when extraneous blank lines are removed even when a rule body cannot be formatted, while the shown expected formatting remains unchanged.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100