rust-lang / rust-lang/rustfmt

gives up on a `box` pattern

Open
#6,650 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-matches
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

The following expression:

matches!(stmt, ast::Stmt{kind: ast::StmtKind::MacCall(box ast::MacCallStmt {style : ast::MacStmtStyle::Braces,..}),..})

refuses to get formatted (line formatted, but exceeded maximum width).

Whereas if I remove the box, it gets formatted just fine:

matches!(
    stmt,
    ast::Stmt {
        kind: ast::StmtKind::MacCall(ast::MacCallStmt {
            style: ast::MacStmtStyle::Braces,
            ..
        }),
        ..
    }
)

(I've never touched rustfmt source code before, but I could try working on this, with some help)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running rustfmt on the reported matches! expression and compare it with the version without box. Trace the formatting path for Rust patterns, then verify that the box form formats successfully without exceeding the maximum width while preserving the expected structure.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.