Inconsistent comment handling in tuple field formatting
Open
Nobody has claimed this yet.
needs-triage
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Given code like this:
struct S {
field1: (/* */),
field2: (/* */u32/* */),
field3: (/* */u32,/* */),
}
rustfmt 1.8.0-stable formats it as:
struct S {
field1: (),
field2: (u32),
field3: (/* */ u32 /* */,),
}
Shouldn't the formatted result be one of the following instead?
struct S {
field1: (/* */),
field2: (/* */ u32 /* */),
field3: (/* */ u32 /* */,),
}
or
struct S {
field1: (),
field2: (u32),
field3: (u32,),
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the reported output from issue #6642 with the tuple-field snippet using rustfmt 1.8.0-stable. Determine whether tuple comments should be preserved or removed consistently, then add regression coverage showing the chosen formatting for all three fields.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100