Improve let-chain indentation
Open
Nobody has claimed this yet.
needs-triage
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Current formatted code:
fn too_long_function_name_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcxxxxxxxxxxxxxxxxxxxx()
-> Option<i32> {
None
}
fn main() {
if let Some(x) =
too_long_function_name_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcxxxxxxxxxxxxxxxxxxxx()
&& x != 0
{
println!("x")
}
}
If you don't pay attention to the = at the end of the previous line,
you may think that this call returns a bool
Expect improved formatted code:
fn too_long_function_name_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcxxxxxxxxxxxxxxxxxxxx()
-> Option<i32> {
None
}
fn main() {
if let Some(x)
= too_long_function_name_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcxxxxxxxxxxxxxxxxxxxx()
&& x != 0
{
println!("x")
}
}
or
fn too_long_function_name_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcxxxxxxxxxxxxxxxxxxxx()
-> Option<i32> {
None
}
fn main() {
if let Some(x) =
too_long_function_name_xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxcxxxxxxxxxxxxxxxxxxxx()
&& x != 0
{
println!("x")
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the two Rust examples in the report, then locate the rustfmt code path responsible for formatting let-chain conditions. Decide which of the two proposed layouts is intended and add a regression test for it. Done means the formatter produces the chosen improved indentation without regressing related let-chain formatting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100