Commented out `macro_rules` arm gets moved after previous arm
Open
Nobody has claimed this yet.
A-comments
C-bug
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
macro_rules! val {
($name:ident) => {
stringify!($name)
};
// ($name:ident $value:literal) => {
// $value
// };
}
gets formatted as
macro_rules! val {
($name:ident) => {
stringify!($name)
}; // ($name:ident $value:literal) => {
// $value
// };
}
If wrap_comments = true is enabled it gets turned into a block comment which was quite a surprise
macro_rules! val {
($name:ident) => {
stringify!($name)
}; /* ($name:ident $value:literal) => {
* $value
* }; */
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the formatting change from the issue, with and without wrap_comments enabled, then trace the macro_rules comment-handling path. Add a regression test covering the commented-out arm and verify that formatting preserves its position and comment style.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100