Add formatting support for the `asm!` macro
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Given a snippet like this
unsafe fn foobar() {
core::arch::asm!("{}",
const X)
}
I'd expect that to format to
unsafe fn foobar() {
core::arch::asm!("{}", const X)
}
but instead nothing happens. Given that these operands are quite new, I suspect this is an oversight.
I'd happily look into fixing this, but I'm not 100% clear on whether the formatting behavior for existing code can be change? Though here I'd clearly consider it a bug.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue by running rustfmt on the provided unsafe function and compare the output with the expected formatting for the asm! operands. Trace how rustfmt handles asm! arguments, then add regression coverage for this snippet; done means the const X operand is kept on the same line as the format string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100