Illegally adds comma to macro invocation
Open
Nobody has claimed this yet.
A-macros
C-bug
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Rustfmt adds a comma to the following and causes a compiler error.
macro_rules! idx {
($(#[$attr:meta])* $vis:vis struct $name:ident; $metadata:ident) => {
$(#[$attr])*
$vis struct $name(usize);
};
}
idx!(
#[derive(Debug)]
pub struct FooIdx; // rustfmt adds a comma here
Meta
);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the Rust macro invocation shown in the issue and inspect rustfmt's handling of this macro syntax. Done means rustfmt no longer inserts a comma after the struct declaration, and the formatted output still compiles.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100