rust-lang / rust-lang/rustfmt

Left shift of chained function calls after indexing

Open
#6,469 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-call-chains I-poor-formatting
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

let right_size = context.wires[self.right]
    .typ
    .try_fully_substitute(&context.type_substitutor)
    .unwrap()
    .unwrap_named()
    .template_args[UUID::from_hidden_value(0)]
.unwrap_value()
.unwrap_integer()
.clone();

This arguably looks odd and should probably be formatted as

let right_size = context.wires[self.right]
    .typ
    .try_fully_substitute(&context.type_substitutor)
    .unwrap()
    .unwrap_named()
    .template_args[UUID::from_hidden_value(0)]
    .unwrap_value()
    .unwrap_integer()
    .clone();
rustfmt --version
rustfmt 1.8.0-stable (90b35a6239 2024-11-26)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running rustfmt 1.8.0-stable on the supplied chained-call example and compare the current output with the proposed formatting. Trace the formatter behavior for method calls after indexing, then verify that the chained calls remain indented consistently without changing other formatting cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.