Block comment inside match adds unnecessary comma
Open
Nobody has claimed this yet.
A-comments
A-matches
C-bug
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Using rustfmt 1.7.1-stable (eeb90cda 2024-09-04), In the following example:
fn main() {
let x: Option<i32> = Some(10);
let value = match x {
Some(i) => i /* comment */,
None => 0
};
println!("{}", value);
}
Rustfmt adds an additional comma before the block comment, which causes the following error:
error: expected pattern, found `,`
--> src/test.rs:4:36
|
4 | Some(i) => i, /* comment */,
| ^ expected pattern
error: aborting due to 1 previous error
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the issue with the Rust match example in the report using rustfmt 1.7.1-stable, then trace how block comments and match-arm commas are handled. Done means rustfmt no longer inserts the extra comma before the comment and the formatted example compiles successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100