rust-lang / rust-lang/rustfmt

Rustfmt removes values from extern static items

Open
#6,267 0 comments 2 reactions 1 assignee View on GitHub

@ytmimi is already working on this.

Since Aug 4, 2024.

A-extern-items C-bug I-changes-semantics
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Rust v1.80 (rustfmt 1.7.0-stable (0514789 2024-07-21)) and Nightly (rustfmt 1.7.1-nightly (64ebd39 2024-08-03)) both remove values from static items:

extern "C" {
    static TEST: i32 = 42;
}

When formatted it gets transformed into:

extern "C" {
    static TEST: i32;
}

Rustfmt showed no error.
This code doesn't actually build in the first place, I'm using it with a proc-macro to implement externalized strings in wasm-bindgen (https://github.com/rustwasm/wasm-bindgen/issues/4031) which allows this to work.

This is similar to #4159.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.