rust-lang / rust-lang/rustfmt

version Two no longer able to format code

Open
#6,157 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments I-trailing-whitespace S-duplicate
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

fn f() {}

fn main() {
    f(0, 1,);        // f()
    //~^ error: this function takes 0 arguments but 2 arguments were supplied
}

with version = "Two"
it looks like rustfmt does no longer know that the comment on line 5 exists, it thus flags " " as

error[internal]: left behind trailing whitespace
 --> /tmp/im/a.rs:5:5:1
  |
5 |
  | ^^^^
  |

which it isnt because there is a comment after the indentation (unless it tries to remove the entire comment which is spooky as well)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running rustfmt with version = "Two" on the Rust snippet in the issue and observe the reported trailing whitespace at the commented argument line. Trace how rustfmt handles that line and its comment; done means the code formats without falsely reporting indentation as trailing whitespace while preserving the comment.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.