rust-lang / rust-lang/rustfmt

Warn or even fail when both rustfmt.toml and .rustfmt.toml exist

Open
#6,135 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-config C-discussion
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

According to the Rust digger report there are at least 35 crates that have both .rustfmt.toml and rustfmt.toml files. If I am not mistake in such case get_toml_path will return the former and disregard the latter.

Would it be a good idea to warn the user in such case or even to fail the formatting process?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at get_toml_path in src/config/mod.rs and inspect how it handles the simultaneous presence of .rustfmt.toml and rustfmt.toml. Clarify whether the intended result is a warning or a formatting failure, then determine how that behavior should be verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.