rust-lang / rust-lang/rustfmt

Multi-line Fn supertraits are indented improperly

Open
#6,127 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

I-poor-formatting
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Multi-line supertraits appear to be insufficiently indented:

trait Foo:
    Fn(
    ReallyLongTypeName,
    ReallyLongTypeName,
    ReallyLongTypeName,
    ReallyLongTypeName,
) -> ReallyLongTypeName
{
}

I'd prefer the later lines to be indented an extra level:

trait Foo:
    Fn(
        ReallyLongTypeName,
        ReallyLongTypeName,
        ReallyLongTypeName,
        ReallyLongTypeName,
    ) -> ReallyLongTypeName
{
}

(playground example)

Thank you!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the formatting difference using the linked Rust Playground example and compare the input with the expected output in the issue. No source file or test is named, so locate the rustfmt formatting entry point for multi-line function-trait supertraits, then add coverage showing the later lines receive the extra indentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.