rust-lang / rust-lang/rustfmt

Spurious semicolon inside closure is not idempotent

Open
#6,116 1 comment 0 reactions 1 assignee View on GitHub

@rscprof is already working on this.

Since Mar 29, 2024.

A-closures A-statements C-bug I-non-idempotency P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

Consider the following snippet.

fn foo() -> fn(i32) -> i32 {
    |a| {
        ;
        a
    }
}

Rustfmt starts by removing that spurious semicolon.

fn foo() -> fn(i32) -> i32 {
    |a| {
        a
    }
}

If run again, it notices that the closure fits on one line.

fn foo() -> fn(i32) -> i32 {
    |a| a
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.