rust-lang / rust-lang/rustfmt

rustfmt removes comments inside parentheses in patterns (PatKind::Paren).

Open
#6,110 1 comment 0 reactions 1 assignee View on GitHub

@yuvraj-wale is already working on this.

Since Mar 11, 2024.

A-comments A-patterns C-bug I-unexpectedly-removes-code
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

  • Issue: rustfmt unexpectedly removes comments inside parentheses in patterns (PatKind::Paren).

  • Example:

    • Input:

      fn main() {
          let (/* */() | ()/* */) = ();
      }
      
    • Output (after formatting):

      fn main() {
          let (() | ()) = ();
      }
      
    • Expected Outcome:

      fn main() {
          let (/* */() | ()/* */) = ();
      }
      
  • Related Issues:

    • This issue, related to PatKind::Paren, partially overlaps with #6044, which focuses on PatKind::Or.
    • Similar to #5780, but the changes here pertain to PatKind::Paren instead of TyKind::Paren.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.