rustfmt deletes comments in "or" patterns
Open
Nobody has claimed this yet.
A-comments
C-bug
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
This:
fn main() {
let (/**/ () /**/ | /**/ () /**/) = ();
}
gets turned into this:
fn main() {
let (() | ()) = ();
}
(play)
cc @fee1-dead
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the minimal Rust reproduction in the issue and run rustfmt to confirm that comments inside the or pattern are removed. Trace rustfmt's handling of or patterns, then add coverage showing that the comments are preserved and verify the formatted output against the example.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100