rust-lang / rust-lang/rustfmt

Gracefully handle full disk instead of erasing file contents

Open
#6,041 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-io A-robustness C-bug P-low
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

From https://news.ycombinator.com/item?id=39121489

I've had cargo fmt eat my files when I was out of disk space. It created a new file, but the file length was 0, and my old file was gone.

rustfmt should produce an explicit error when encountering a full disk and avoid attempting to replace an existing file with one that has no content. This later case might be a good unconditional sanity check against other potential bugs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing rustfmt behavior when the disk is full and trace how it replaces an existing file. The work is done when rustfmt reports an explicit error and never replaces a file with an empty result, including the unconditional empty-content sanity check described in the issue.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.