rust-lang / rust-lang/rustfmt

rustfmt stops formatting after line comment following `..` in a struct pattern

Open
#6,040 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-comments A-matches
Dominant language
Rust
Stars
7k
Forks
1.1k
Avg merge
2d 13h
Merged PRs (30d)
24

Description

I wondered why suddenly only half of my file got formatted and boiled down the code to the following MWE:

fn main() {
match e { // this line still gets formatted
        MyStruct {
            field_a,
            .. // this comment here apparently causes trouble
        } => (),
_ => (), // this line is no longer formatted
    };
}

Notably, rustfmt does not complain, it just ignores everything after the offending comment and formats the file only up to that point.

I saw that there are already many open issues revolving around comments, so my apologies if this exact issue has been reported before.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running rustfmt on the Rust MWE in the issue and inspect its comment-handling behavior around the .. in the struct pattern. Trace where formatting stops after the line comment, then add a regression test showing that the entire input is formatted rather than silently truncated.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.