Only generic `impl` blocks get formatted in macros
Open
Nobody has claimed this yet.
A-macros
C-bug
I-unformatted-code
- Dominant language
- Rust
- Stars
- 7k
- Forks
- 1.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 24
Description
Ideally, both should be formatted.
Test:
> echo "m!(impl One {}); m!(impl<> Two {});" | rustup run nightly rustfmt
m!(impl One {});
m!(
impl Two {}
);
> rustup run nightly rustfmt -Vv
rustfmt 1.7.0-nightly (88189a71 2024-01-19)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the behavior with the shell command in the issue using the specified nightly rustfmt version, then trace the formatter's handling of macro contents and impl blocks. Done means both impl One {} and impl<> Two {} forms are formatted consistently, with regression coverage for the demonstrated input.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100